(A014) [ModelExecution] update code for execution of a compiled model#424
Merged
adeas31 merged 1 commit intoOpenModelica:masterfrom Mar 12, 2026
Merged
(A014) [ModelExecution] update code for execution of a compiled model#424adeas31 merged 1 commit intoOpenModelica:masterfrom
adeas31 merged 1 commit intoOpenModelica:masterfrom
Conversation
syntron
changed the title
syntron
force-pushed
the
ModelExecution
branch
4 times, most recently
from
bd659ba to
20df470
Compare
Member
|
Please rebase. |
[ModelExecution*] create classes to handle model execution * rename ModelicaSystemCmd => ModelExecutionCmd * rename OMCSessionRunData => ModelExecutionData * create class ModelExecutionException * move some code: * OMCSession.omc_run_data_update() => merge into ModelExecutionCmd.define() * OMCSession.run_model_executable() => ModelExecutionData.run() [test_ModelicaSystemCmd] update unittest [ModelExecutionData] include the original exception if reraised as ModelExecutionException [ModelicaSystem] fix usage of ModelicaSystemCmd
adeas31
approved these changes
Mar 12, 2026
| if modelname is None: | ||
| raise ModelicaSystemError("Missing model name!") | ||
| if model_name is None: | ||
| raise ModelExecutionException("Missing model name!") |
Member
There was a problem hiding this comment.
I wonder why are we doing this?
model_name is allowed to be omitted (= None). But if it is omitted or explicitly passed as None, we raise an exception.
It is better to do model_name: str and we can still keep the check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see PR #404